LSP: Add Go to Definition support for Ast::Variable
#619
+3,697
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gdotdesign
added
enhancement
gdotdesign
requested changes
Jul 20, 2023
|
It looks very good! Thank you for adding a huge amount of tests 🙏 Please update the PR from the master branch and it should be ready to go from my side 👍 |
gdotdesign
approved these changes
Jul 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Been through a couple of iterations of this and still not terribly happy with the code (could do with another pass or two 😅), but this PR adds "Go to Definition" support for the majority of
Ast::Variable's.Here's a quick example of it in action:
2023-07-05.22-17-22.mp4
Will keep testing as I'm sure there's a bunch of weird and wonderful ways of using Mint that I haven't accounted for, but it's pretty handy as is!
Note: There are a couple of tests that will fail until the fix from #615 has been merged